RE: Java - Bin2Text - Second Draft |
||
 Tr flamebalrog On 2005-02-24 20:22:31, SAJChurchey wrote > > > private static int bin2decimal(String binary){ > int decimal = 0; > for(int i = binary.length() - 1;i >= 0;--i){ > int asciiValue = binary.charAt(i) - '0'; > decimal += Math.pow(2,i) * asciiValue; > }//end for > return decimal; > } > Is Math.pow() faster than shift+or ? Also, the result is an integer, not a decimal. i.e. : naming the function bin2decimal could lead to misunderstanding (like decimal<==>represented with digits [0-9], which is probably not true 'coz I doubt an int is represented like that in memory...but I've never been in there so...). private static int bin2int(String binary){
int result = 0;
for(int i=0 ; i<binary.length ; i++) {
int bitValue = binary.charAt(i) - '0';
result=(result<<1)|bitValue;
}// avoid useless comments
return result;
}
- Is it a feature or a bug ? -
Replies:
|
||
| CyberArmy::Forum v0.6 Generated In 0.06617 seconds |
2005-02-15 17:19:31
2006-01-03 05:04:05
2005-03-21 03:08:22
2005-03-14 19:01:39
2005-03-18 17:04:23
2005-02-17 20:09:14
2005-02-15 20:12:52